Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): text input width calculation #8063

Merged
merged 2 commits into from
Oct 12, 2016
Merged

fix(input): text input width calculation #8063

merged 2 commits into from
Oct 12, 2016

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Sep 13, 2016 •
edited
Loading

Short description of what this resolves:

Issue that the width property is invalid ex;
width: calc(100% - 8px - 0); which is not a valid calc value.

Changes proposed in this pull request:

  • Add a part of the calculation using SASS, Add the margin-left and margin right using SASS and then subtract the total using the css calc function. Compiled down would be calc(100% - 8px); in case you have a left margin of 10px and right of 20px it would be calc(100% - 30px);

Ionic Version: 2

Fixes: #7388

@alan-agius4
Copy link
Contributor Author

Any update please?

@adamdbradley adamdbradley added this to the 2.0.0-rc.1 milestone Oct 3, 2016
@adamdbradley adamdbradley added the v2 label Oct 3, 2016
@brandyscarney brandyscarney merged commit 21fa5cd into ionic-team:master Oct 12, 2016
@brandyscarney
Copy link
Member

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
3 participants
@alan-agius4 @brandyscarney @adamdbradley