Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popover): popover can now be used inline #23231

Merged
merged 22 commits into from
May 3, 2021
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Apr 23, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • Popover currently is only available via popoverController

What is the new behavior?

  • Popover is now available to use inline in your component template
  • Popover is now a shadow component

Does this introduce a breaking change?

  • Yes
  • [] No

Other information

In order for slots to work properly across framework integrations, ion-popover needs to be converted to shadow. As a result, I exposed a few shadow parts so that users can still style certain internals.

More robust documentation and usage examples will be added in the desktop popover PR. I wanted to split the inline popover feature out to its own PR to make it easier to review. I will be doing the same thing for ion-modal after popover is done in prep for our ion-datetime work.

A few notes on things I added:

  • The isOpen property is used in Ionic Vue and Ionic React to programmatically open/close a popover. I moved it to the core component so that Angular and Vanilla JS users can use this feature as well.
  • The willPresent, didPresent, willDismiss, and didDismiss events are shorthands used in Ionic Vue and Ionic React so devs don't need to keep writing ionPopover every time they want to listen for a popover lifecycle event. I moved those to the core component too so that Angular and Vanilla JS users can use these as well.

The above 2 notes also help reduce the amount of framework-specific code we need to write an maintain.

  • Another noteworthy change is that framework-specific delegates are no longer required when writing popover inline. This is because when you write ion-popover inline, the framework takes care of rendering it, so the popover is already created within the JS Framework's application context. Framework delegates are still needed for popoverController since those are initially created outside of the JS Framework's app context.

@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package labels Apr 23, 2021
Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really solid! Great work.

@liamdebeasi liamdebeasi merged commit 308fa1c into next May 3, 2021
@liamdebeasi liamdebeasi deleted the inline-popover branch May 3, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants