Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popover): add desktop support #23258

Merged
merged 34 commits into from
May 10, 2021
Merged

feat(popover): add desktop support #23258

merged 34 commits into from
May 10, 2021

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented May 3, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #21599

What is the new behavior?

  • Added ability to nest popovers (I.e. nested desktop context menus)
  • Added ability to display popovers on different sides of trigger
  • Added ability to align popovers with trigger
  • Added ability to show popover on click, hover, or context menu relative to a designated trigger
  • Added ability to disable arrow on ios
  • Added ability to auto dismiss popover when content is selected
  • Added ability to display popover relative to trigger or x/y coordinates of click event
  • Added ability to make popover same width as trigger element
  • Added offset CSS variables
  • Animations are now snappier

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label May 3, 2021
@liamdebeasi liamdebeasi linked an issue May 3, 2021 that may be closed by this pull request
@bitflower
Copy link
Contributor

Hi @liamdebeasi, I wonder if an issue I have encountered recently is related. It's also in the desktop context. Modal though, but as I see from the code all things overlays are interrelated.

#23278

Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks really solid here! Dropped a view comments that are definitely optional/opinionated

@liamdebeasi liamdebeasi merged commit a67a0fa into next May 10, 2021
@liamdebeasi liamdebeasi deleted the next-popover-2 branch May 10, 2021 21:37
@liamdebeasi
Copy link
Contributor Author

Need to add tests for framework-specific integrations (namely react and angular). Will add this in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: improve popover position customization
3 participants