-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(popover): add desktop support #23258
Conversation
Hi @liamdebeasi, I wonder if an issue I have encountered recently is related. It's also in the desktop context. Modal though, but as I see from the code all things overlays are interrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks really solid here! Dropped a view comments that are definitely optional/opinionated
Need to add tests for framework-specific integrations (namely react and angular). Will add this in a separate PR. |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: resolves #21599
What is the new behavior?
Does this introduce a breaking change?
Other information