Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datetime): add new calendar picker #23416

Merged
merged 25 commits into from
Jun 16, 2021
Merged

feat(datetime): add new calendar picker #23416

merged 25 commits into from
Jun 16, 2021

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jun 4, 2021 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #19423

What is the new behavior?

  • Adds the new calendar style picker for iOS and MD

Does this introduce a breaking change?

  • Yes
  • No

Other information

liamdebeasi and others added 17 commits May 10, 2021 14:56
@liamdebeasi
feat(datetime): add base new datetime component (#23286)
21d380d
@liamdebeasi
feat(datetime): add header and footer (#23288)
991545e
@liamdebeasi
feat(datetime): add calendar picker on ios and md (#23325)
a01c107
@liamdebeasi
sync with next
f5e1f17
@liamdebeasi
feat(datetime): add time picker (#23353)
73de467
@liamdebeasi
feat(datetime): add month and year picker (#23374)
955cbea
@liamdebeasi
feat(datetime): add presentation, and default title/button apis (#23380)
19040ba
@liamdebeasi
sync with next
13f0c4b
@liamdebeasi
fix(datetime): events are now emitted, value property now respected (#…
d5152d1 
…23399)
@liamdebeasi
fix(datetime): all scrollable views are now correctly snapped into pl…
2e23b8b 
…ace on load (#23402)
@liamdebeasi
fix(datetime): use fixed pixel width for IO
1a1b7fa
@liamdebeasi
chore(datetime): remove displayFormat and displayTimezone properties (#…
53b0181 
…23404)
@liamdebeasi
docs(datetime): add e2e tests (#23405)
e99e5ee
@liamdebeasi
fix(datetime): keyboard navigation now accounts for max and min dates
3fde7ce
@liamdebeasi
fix(datetime): generateTime now accounts for max/min values that have…
c6d5480 
… no hour or minute
@liamdebeasi
fix(datetime): calendar body properly forwards focus to inner day
88932ca
@liamdebeasi
feat(datetime): implement dayValues, minuteValues, monthValues, and y…
ca034ef 
…earValues (#23414)
@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package labels Jun 4, 2021
@DwieDima
Copy link
Contributor

DwieDima commented Jun 4, 2021

oooohh cant wait to see that in action!!

@liamdebeasi liamdebeasi merged commit 932d3ca into next Jun 16, 2021
@liamdebeasi liamdebeasi deleted the next-datetime branch June 16, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamdebeasi @DwieDima