Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): build for angular 12.0 #23970

Merged
merged 4 commits into from
Oct 15, 2021
Merged

feat(angular): build for angular 12.0 #23970

merged 4 commits into from
Oct 15, 2021

Conversation

mhartington
Copy link
Contributor

This adds support for Angular v12 tooling and library distribution
Ref #23890

https://angular.io/guide/creating-libraries#building-libraries-with-ivy

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package labels Sep 22, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the build here? Looks like linter and E2E are failing.

@mhartington mhartington force-pushed the partial-ivy-mode branch 2 times, most recently from 7d232db to 5ae69dc Compare October 13, 2021 21:49
This adds support for Angular v12 tooling and library distribution
Ref #23890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants