fix(item): remove empty padding space for item bottom #24323
Conversation
sean-perkins
changed the title
core/src/components/item/item.scss
Outdated
| 0, | ||
| var(--inner-padding-end), | ||
| 0, | ||
| calc(var(--padding-start) + var(--ion-safe-area-left, 0px) + var(--bottom-padding-start)) |
There was a problem hiding this comment.
--bottom-padding-start is not part of the public API, and defaults to 0px, so do we even need to use it anymore?
There was a problem hiding this comment.
I'd feel comfortable removing it. Especially as another draft PR exposes .item-bottom as a shadow part that would allow developers to customize these styles in 6.1.
Is our stance that anything documented is public API and any other CSS variables are internal use and lower concern of affecting our release cycle?
There was a problem hiding this comment.
Yep exactly. If it's not in the comments above in that item.scss file (this causes stencil to autogenerate it in the docs.json file) then it's internal.
|
Is this merged into @ionic/vue? I am using the vue implementation of ionic, v6.1.11 but yet facing the empty space from .item- bottom class |
|
This was released in Ionic 6.0.1: https://github.com/ionic-team/ionic-framework/releases/tag/v6.0.1 Could you create a separate issue with a minimal reproduction? |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The
.item-bottomimplementation forion-item, incorrectly pushes the item's contents regardless if help/error text is present.Issue Number: Resolves #23892
What is the new behavior?
The reserved space for the help/error text will not push the container space when the slot is unused.
Does this introduce a breaking change?
Other information
Changes for help/error text and the item bottom container were introduced with: #23354