Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(worker-plugin): transfer OffscreenCanvas #2849

Merged
merged 2 commits into from
Mar 25, 2021
Merged

fix(worker-plugin): transfer OffscreenCanvas #2849

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe59ced
fix(worker-plugin): transfer OffscreenCanvas
Mar 10, 2021
a55e935
fix(worker-plugin): transferable objects
Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/compiler/bundle/worker-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,10 @@ const workerMsgId = '${workerMsgId}';
const workerMsgCallbackId = workerMsgId + '.cb';
const getTransferables = (value) => {
if (!!value) {
if (value instanceof ArrayBuffer) {
if (value instanceof ArrayBuffer
|| value instanceof MessagePort
|| value instanceof ImageBitmap
|| value instanceof OffscreenCanvas) {
return [value];
}
if (value.constructor === Object) {
Expand Down Expand Up @@ -345,7 +348,10 @@ export const createWorkerProxy = (worker, workerMsgId, exportedMethod) => (
const postMessage = (w) => (
w.postMessage(
[workerMsgId, pendingId, exportedMethod, args],
args.filter(a => a instanceof ArrayBuffer)
args.filter(a => a instanceof ArrayBuffer
|| a instanceof MessagePort
|| a instanceof ImageBitmap
|| a instanceof OffscreenCanvas)
)
);
if (worker.then) {
Expand Down