Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new new sdk (RFC FS-1032) #165

Closed
2 tasks done
enricosada opened this issue Jun 9, 2017 · 3 comments · Fixed by #166
Closed
2 tasks done

Support new new sdk (RFC FS-1032) #165

enricosada opened this issue Jun 9, 2017 · 3 comments · Fixed by #166
Assignees

Comments

@enricosada
Copy link
Contributor

enricosada commented Jun 9, 2017

The FSharp.NET.Sdk is now deprecated in favor of Microsoft.NET.Sdk, ref https://github.com/fsharp/fslang-design/blob/master/RFCs/FS-1032-fsharp-in-dotnet-sdk.md

How to test it:

There is little difference from FSAC side, target files are pretty much the same, same msbuild based:

  • how to detected new sdk (vs old project cracker based):

    <Project Sdk="Microsoft.NET.Sdk">

    instead of

    <Project Sdk="FSharp.NET.Sdk;Microsoft.NET.Sdk">

    => is already ok with 13a2f30

  • fsc args, file path: the old implementation used always full path for files. Now path of files passed to fsc are relative to fsproj directory. (wip in add sdk 2.0 support #166)

Instead of adding a target file inside obj dir, is possibile to use FSharpDesignTimeTargetsPath property to pass the target file to import (more clean, work the same, so just an enhancement). Do this is is detected the sdk as point 1 => added https://github.com/enricosada/dotnet-proj-info/issues/4 to track that

/cc @Krzysztof-Cieslak @rneatherway @dsyme

@enricosada
Copy link
Contributor Author

enricosada commented Jun 10, 2017

@Krzysztof-Cieslak @rneatherway @kjnilsson if possibile can you update editors to use this FSAC 6de0fdb (no rush :D), will be really good for testing .net core sdk 2.0 (and that mean next VS 2017 sdk too).

everything should work like with 1.0, both are supported (it's pratically the same :D)

/cc @dsyme @alfonsogarciacaro @neoeinstein @forki

@rneatherway
Copy link
Contributor

rneatherway commented Jun 10, 2017 via email

@enricosada
Copy link
Contributor Author

Added a 1.0 vs 2.0 summary in https://github.com/dotnet/netcorecli-fsc/wiki/How-to-migrate-1.0-projects-to-2.0#summary-of-changes-from-10-to-20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants