Extend FS25 codefix to allow generating match cases from scratch #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
approved these changes
Aug 19, 2024
| @@ -211,6 +211,19 @@ let private tryFindPatternMatchExprInParsedInput (pos: Position) (parsedInput: P | |||
| | _ -> None | |||
| else | |||
| None) | |||
| |> Option.orElseWith (fun () -> | |||
| if synMatchClauseList.IsEmpty then | |||
| match debugPoint with | |||
There was a problem hiding this comment.
Any reason you went with this extra check for the debug point.
I don't think it matters, checking if synMatchClauseList.IsEmpty probably is enough.
There was a problem hiding this comment.
I think I copied this check from preceding "branch" of orElseWith call chain. Honestly, I don't know what DebugPointAtBinding is here for 😅
|
Wow, I'm so sorry I missed this. I've kick-started the checks, will take a look once those report back. This looks awesome! |
|
Checks are green! Thanks for adding the test and a cool feature overall. I'll merge and we can work on a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
I've made an addition to existing FS25 "Generate union pattern match case". Basically, it allows applying this codefix to an empty
match ... with, so user isn't required to write first case branch for the codefix to work. I think that this codefix might be useful in slightly different contexts. Current implementation is more suitable for cases when already existing Union type gets extended, and therefore already existing match expression becomes non-exhaustive. But in my practice, when I'm writing small programs from scratch, I usually have a different situation cause I'm writing completely new match expressions.I tried to develop it in backward-compatible way, so that previous logic for the codefix stays intact, and the code only falls back to a new logic if the original one is unable to produce results.