Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to net8 SDK #1313

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Bump to net8 SDK #1313

merged 1 commit into from
Jul 18, 2024

Conversation

Smaug123
Copy link
Contributor

@Smaug123 Smaug123 commented Jul 13, 2024

net7 is end-of-life.

I haven't touched the existing net7 tests (e.g. test/FsAutoComplete.Tests.Lsp/TestCases/DependentFileChecking/CrossProject-net7.0/App/App.fsproj or benchmarks/benchmarks.fsproj ).

@Smaug123
Copy link
Contributor Author

The test failures appear to be present on main (e.g. https://github.com/ionide/FsAutoComplete/actions/runs/9874666303/job/27269560192 ).

Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Smaug123
Copy link
Contributor Author

(I don't have write access to this repo, I believe, so can't merge this.)

@TheAngryByrd TheAngryByrd merged commit fc79e99 into ionide:main Jul 18, 2024
26 checks passed
@TheAngryByrd
Copy link
Member

Yeah, I meant to merge it but got distracted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants