Remove --background-service-enabled CLI option
#952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had been thinking about this, but I was going to wait to remove it until we'd done a release of FSAC/Ionide that contained the backgroundservice removal. To have overlap and a bit of safety. I think there's also a way to have System.CommandLine ignore unrecognized options as well, if that would be safer. |
|
@Krzysztof-Cieslak There is no need for this option anymore to run FsAutoComplete on the terminal for LSP support? For a test I removed the option and appears that is working fine on my environment. |
|
correct! we can merge this now that we've had enough time for compatible versions to go out. |
|
@baronfel Cool! I will follow this change to add this behaviour on nvim-lspconfig that we use on Neovim. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change - if the editor will try to start FSAC with this parameter it will crash.