feat(relay):Audioobserver supported on relaying SFU #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this is something under my radar, but needs discussions, since this would work only if you relay the full session, so peers in relayed streams can get audio levels correctly. So we can either specify the audio level as a Relay option or make a session helper to relay sessions to other SFU, that would help for horizontal scaling. Edit: Sorry I thought it was an Issue, happy to merge ! |
OrlandoCo
requested changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we relay audio track by ortc api,the sdp has no RTPHeader "urn:ietf:params:rtp-hdrext:ssrc-audio-level", so the relaying sfu can not observer the relayed audio track.