Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(formating and typing): add more type hints [DNS-1270] #6

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

zak905
Copy link
Contributor

@zak905 zak905 commented Apr 9, 2024

No description provided.

@zak905 zak905 force-pushed the DNS_1270_more_refactoring branch from 8726ae7 to 6db9281 Compare April 9, 2024 13:34
@zak905 zak905 changed the title refactor(formating and typing): add more type hints refactor(formating and typing): add more type hints [DNS-1270] Apr 9, 2024
@zak905 zak905 requested a review from cbeti-ionos April 9, 2024 13:41
Copy link
Member

@cbeti-ionos cbeti-ionos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@zak905
Copy link
Contributor Author

zak905 commented Apr 10, 2024

thanks for the code review @cbeti-ionos

@zak905 zak905 merged commit 50de9b9 into init Apr 10, 2024
1 check passed
@zak905 zak905 deleted the DNS_1270_more_refactoring branch April 10, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants