fix: wrap controlplaneEndpoint in [], if provided address is an IPv6 …

…address

Fixes #143.

internal/webhook/proxmoxcluster_webhook.go

@@ -96,14 +96,31 @@ func validateIPs(cluster *infrav1.ProxmoxCluster) error {
 
 	gk, name := cluster.GroupVersionKind().GroupKind(), cluster.GetName()
 
-	ipAddr, err := netip.ParseAddrPort(fmt.Sprintf("%s:%d", ep.Host, ep.Port))
+	endpointHostIp := ep.Host
+
+	addr, err := netip.ParseAddr(endpointHostIp)
+	if err != nil {
+		return apierrors.NewInvalid(
+			gk,
+			name,
+			field.ErrorList{
+				field.Invalid(
+					field.NewPath("spec", "controlplaneEndpoint"), endpointHostIp, "provided endpoint address is not a valid IP"),
+			})
+	}
+	// If the passed control-plane endppoint is an IPv6 address, wrap it in [], so it can properly pass ParseAddrPort validation
+	if addr.Is6() {
+		endpointHostIp = fmt.Sprintf("[%s]", ep.Host)
+	}
+
+	ipAddr, err := netip.ParseAddrPort(fmt.Sprintf("%s:%d", endpointHostIp, ep.Port))
 	if err != nil {
 		return apierrors.NewInvalid(
 			gk,
 			name,
 			field.ErrorList{
 				field.Invalid(
-					field.NewPath("spec", "controlplaneEndpoint"), fmt.Sprintf("%s:%d", ep.Host, ep.Port), "provided endpoint is not in a valid IP and port format"),
+					field.NewPath("spec", "controlplaneEndpoint"), fmt.Sprintf("%s:%d", endpointHostIp, ep.Port), "provided endpoint is not in a valid IP and port format"),
 			})
 	}
 

internal/webhook/proxmoxcluster_webhook_test.go

@@ -47,7 +47,7 @@ var _ = Describe("Controller Test", func() {
 		It("should disallow invalid endpoint IP", func() {
 			cluster := invalidProxmoxCluster("test-cluster")
 			cluster.Spec.ControlPlaneEndpoint.Host = "invalid"
-			g.Expect(k8sClient.Create(testEnv.GetContext(), &cluster)).To(MatchError(ContainSubstring("provided endpoint is not in a valid IP and port format")))
+			g.Expect(k8sClient.Create(testEnv.GetContext(), &cluster)).To(MatchError(ContainSubstring("provided endpoint address is not a valid IP")))
 		})
 
 		It("should disallow invalid IPV4 IPs", func() {