Bind Proxmoxmachine Webhook

[mcbenjemaa]

Summary:

In This PR #42, the machine webhook is introduced/

but the binding was not implemented.

[65278]

LGTM
edit: (on second thought, no)

[65278]

You're aware that this is double pasted?
These code blocks are exactly the same.

cluster-api-provider-proxmox/cmd/main.go

Line 143 in 7b1af3e

if err = (&webhook.ProxmoxCluster{}).SetupWebhookWithManager(mgr); err != nil {

cluster-api-provider-proxmox/cmd/main.go

Line 147 in 7b1af3e

if err = (&webhook.ProxmoxMachine{}).SetupWebhookWithManager(mgr); err != nil {

[mcbenjemaa]

What is that?

[mcbenjemaa]

yeah, that's webhook for ProxmoxCluster and the other is for ProxmoxMachine

[65278]

Lines 143 to 146 and Lines 147 to 150 are the exact same code block. To me it looks like you're just pasting the same block for no reason.

[mcbenjemaa]

not exactly:
both types use the same function name, SetupWebhookWithManager()

(&webhook.ProxmoxCluster{})
(&webhook.ProxmoxMachine{}

[65278]

Must be going blind.