This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
add defaultState from the original reducers to the namespaced ones #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaKolokoltsev
force-pushed
the
fix-prefilled-state
branch
from
d8ef2e6
to
e0b86c6
Compare
NikitaKolokoltsev
force-pushed
the
fix-prefilled-state
branch
from
e0b86c6
to
2f9afe6
Compare
taleh007
reviewed
Dec 11, 2018
|
|
||
| const reduxSpecific = (action) => action.type.startsWith(REDUX_PREFIX) | ||
|
|
||
| export default reduxSpecific |
| @@ -0,0 +1,13 @@ | |||
| /** | |||
| * Copyright 2017, IOOF Holdings Limited. | |||
There was a problem hiding this comment.
Suggested change
| * Copyright 2017, IOOF Holdings Limited. | |
| * Copyright 2018, IOOF Holdings Limited. |
There was a problem hiding this comment.
Github wont let me commit this (no permission to push the change, presumable to your fork), but yes.
mpeyper
reviewed
Dec 12, 2018
|
|
||
| const processAction = (namespace) => (action, callback, defaultValue) => { | ||
| if (!namespace || isGlobal(action)) { | ||
| if (!namespace || isGlobal(action) || isReduxSpecific(action)) { |
There was a problem hiding this comment.
I'd be tempted to move this into the isGlobal check. Essentially we are saying that redux actions are always global actions.
|
|
||
| const processAction = (namespace) => (action, callback, defaultValue) => { | ||
| if (!namespace || isGlobal(action)) { | ||
| if (!namespace || isGlobal(action) || isReduxSpecific(action)) { |
There was a problem hiding this comment.
This case should get a specific unit test.
There was a problem hiding this comment.
I'll add tests a bit later
|
Oh, I forgot to do the usual preamble... Thanks for taking the time to improve |
|
Thanks for this. I'll put together a release later today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the mess in commits :)