Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pkg_resources and go fully to pyproject.toml #1059

Closed

Conversation

ChrisBarker-NOAA
Copy link
Contributor

This PR removes the deprecated pkg_resources.

It also updates to a fully pyproject.toml based build / install, building off the work in: #1024

Looking now, it seems that #1039 is in fact pretty much the same thing -- wish I'd noticed that earlier!

Sorry to put two things in one PR -- I had done one, and didn't realize how much. was involved in pkg_resources.

Anyway, it would be great if either this or #1039 could be merged.

@ChrisBarker-NOAA
Copy link
Contributor Author

Hmm -- test failing, due to bad yaml file:

Invalid workflow file: .github/workflows/default-tests.yml#L24
The workflow is not valid. .github/workflows/default-tests.yml (Line: 24, Col: 22): The expression is not closed. An unescaped ${{ sequence was found, but the closing }} sequence was not found.

I didn't touch that file, so ???

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 80.69%. Comparing base (c137e28) to head (2f9c5ae).
Report is 7 commits behind head on develop.

Files Patch % Lines
compliance_checker/cf/util.py 33.33% 2 Missing ⚠️
compliance_checker/suite.py 77.77% 2 Missing ⚠️
cchecker.py 0.00% 1 Missing ⚠️
compliance_checker/base.py 66.66% 0 Missing and 1 partial ⚠️
compliance_checker/cfutil.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1059      +/-   ##
===========================================
- Coverage    82.14%   80.69%   -1.46%     
===========================================
  Files           24       25       +1     
  Lines         5170     5267      +97     
  Branches      1242     1261      +19     
===========================================
+ Hits          4247     4250       +3     
- Misses         623      716      +93     
- Partials       300      301       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcermauwedu
Copy link

Using importlib.metadata.entry_points(group= forces the minimum python to 3.10. I was struggling in python 3.9. The workflow default-tests.yml may need to drop 3.8 and 3.9. I will wait for this PR to continue with the pytest fixes in #1056.

@ChrisBarker-NOAA
Copy link
Contributor Author

Now that #1039 has been merged, I'm going to update this. closing for now.

Thanks for the 3.10 hint -- that's where I was testing, but it wasn't clear from the docs which features were added when to the stdlib. I'll use the backported version for older versions.

@ChrisBarker-NOAA
Copy link
Contributor Author

OK -- here it is: #1060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants