-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pkg_resources and go fully to pyproject.toml #1059
Conversation
…into pyproject_toml
Hmm -- test failing, due to bad yaml file: Invalid workflow file: .github/workflows/default-tests.yml#L24 I didn't touch that file, so ??? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1059 +/- ##
===========================================
- Coverage 82.14% 80.69% -1.46%
===========================================
Files 24 25 +1
Lines 5170 5267 +97
Branches 1242 1261 +19
===========================================
+ Hits 4247 4250 +3
- Misses 623 716 +93
- Partials 300 301 +1 ☔ View full report in Codecov by Sentry. |
Using |
Now that #1039 has been merged, I'm going to update this. closing for now. Thanks for the 3.10 hint -- that's where I was testing, but it wasn't clear from the docs which features were added when to the stdlib. I'll use the backported version for older versions. |
OK -- here it is: #1060 |
This PR removes the deprecated pkg_resources.
It also updates to a fully pyproject.toml based build / install, building off the work in: #1024
Looking now, it seems that #1039 is in fact pretty much the same thing -- wish I'd noticed that earlier!
Sorry to put two things in one PR -- I had done one, and didn't realize how much. was involved in pkg_resources.
Anyway, it would be great if either this or #1039 could be merged.