Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag fixes #924

Merged
merged 2 commits into from
May 2, 2022
Merged

Flag fixes #924

merged 2 commits into from
May 2, 2022

Conversation

benjwadams
Copy link
Contributor

Fixes to flags:

Fixes single-valued/scalar flag_values test cases, including an
elementwise comparison against flag_masks.  Fixes ioos#922.
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #924 (dfd8b34) into master (f132cc3) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #924      +/-   ##
==========================================
+ Coverage   78.58%   78.72%   +0.13%     
==========================================
  Files          23       23              
  Lines        5259     5264       +5     
  Branches     1307     1307              
==========================================
+ Hits         4133     4144      +11     
+ Misses        834      829       -5     
+ Partials      292      291       -1     
Impacted Files Coverage Δ
compliance_checker/cf/cf_1_6.py 88.75% <100.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f132cc3...dfd8b34. Read the comment docs.

@benjwadams
Copy link
Contributor Author

@pp-mo, I can't add you as a reviewer presently, but please see if this fixes issues you were having with #992.

@pp-mo
Copy link

pp-mo commented May 1, 2022

see if this fixes issues you were having with #992.

Thanks, yes it does.
Closed #924 in anticipation.

@benjwadams benjwadams merged commit 0949e3b into ioos:master May 2, 2022
@benjwadams benjwadams deleted the flag_fixes branch May 2, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants