-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GHA to convert CDL <-> NC #70
Conversation
1b7250d
to
be19443
Compare
I'd like to wait for @srstsavage comments on #65 (comment) before we commit to this path. |
@ocefpaf I like the Also |
This approach using CDL for text representation looks great! I think I favor |
I'm in favor of |
Option PS: @MathewBiddle it is similar to what we did in the metrics repository in ioos/ioos_metrics#65 |
@ocefpaf I can't say I understand the GHA code at quick glance, but if you say this is good as is with the latest commit for option We could test this by moving existing datasets under a hierarchy like I started to do by adding the |
That's awesome, it ran already by picking up the existing |
The current script I'm using to convert will fail in that scenario but it should be an easy fix. We don't look at any subdirectories at the moment. |
.nc
files in the datasets folder to and from.cdl
if the one or the other is not present.Below is how the file tree will look like with this option. A Diffable CDL and the binary netCDF4 file. Contributor can commit one or the other and this GitHub Action will prepare the missing part. The decision we need to make on [1] is:
a. We amend the contributor PR with the new file: Elegant, few PRs, but can lead to confusion b/c we will be writing over something that is probably in flux and some contributors are not too familiar with GitHub to work that out.
b. Send a fresh PR from main so the pending file will be added as soon as the PR adding the file was merged.
c. Do not add any file, just fail the PR and ask the contributor to convert and commit it.
I'm inclined to
b
orc
.