Update howto.md #17
Merged
Update howto.md #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding guidance for mermaid diagrams from ioos/documentation-theme-jekyll#16 (comment)
fixing some formatting issues
ocefpaf
reviewed
Jun 13, 2024
ocefpaf
reviewed
Jun 13, 2024
Co-authored-by: Filipe <[email protected]>
Co-authored-by: Filipe <[email protected]>
|
Worked!! |
|
@mwengren please review and merge when ready. Thanks! |
|
Weird, when I do either 'view rich diff' or view raw file, it doesn't render the mermaid diagram (maybe that's to be expected), but I'm sure it must work, so I'll just merge. Thanks! |
|
It's probably something to do with the javascript not on that rich diff html page. Seems to render fine on the website: |
|
Yep. While GitHub added mermaid support for PRs and issues text boxes, they did not add it to file previews. Makes sense b/c if they start adding all sort of JS support the preview would be super bloated, slow, and unsafe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding guidance for mermaid diagrams from ioos/documentation-theme-jekyll#16 (comment)
@ocefpaf @mwengren please review and merge if you approve. Thanks!