feat: turn off Nagle's algorithm #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihirn
commented
Aug 10, 2023
src/net/mod.rs
Outdated
| Ok(_) => Ok(Stream { | ||
| inner: StreamImpl::Tcp(s), | ||
| }), | ||
| Err(x) => Err(x), |
There was a problem hiding this comment.
If we do decide that erroring out is the best option, can change this to a s.set_nodelay(true)?, but this is easier until we figure out semantics.
There was a problem hiding this comment.
Best-effort is probably fine, with debug logging before returning.
There was a problem hiding this comment.
Ack, that's probably the best option.
thinkingfish
approved these changes
Aug 10, 2023
Nagle's algorithm prevents transmission of small packets as long as there are outstanding unacknowledged packets, instead buffering data locally. When combined with delayed acknowledgements, this can lead to poor latency with both ends of the connection waiting for each other. Turn off Nagle's algorithm by default to improve latency.
swlynch99
reviewed
Aug 10, 2023
Comment on lines
+74
to
+77
| let res = s.set_nodelay(true); | ||
| if res.is_err() { | ||
| eprintln!("Error setting TCP_NODELAY: {:?}", res.err()); | ||
| } |
There was a problem hiding this comment.
I realize this is already merged but in the future it would be cleaner to do
if let Err(e) = s.set_nodelay(true) {
eprintln!("Error setting TCP_NODELAY: {e:?}");
}
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nagle's algorithm prevents transmission of small packets as long as
there are outstanding unacknowledged packets, instead buffering data
locally. When combined with delayed acknowledgements, this can lead
to poor latency with both ends of the connection waiting for each other.
Turn off Nagle's algorithm by default to improve latency.