Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger workers #580

Merged
merged 36 commits into from
May 12, 2021
Merged

Ledger workers #580

merged 36 commits into from
May 12, 2021

Conversation

thibault-martinez
Copy link
Member

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@Alex6323
Copy link
Contributor

Are we in a hurry with this? Because otherwise I would wait until we merged the pruning logic to cpt2, and include it in this PR? It's not quite a small addition to bee-ledger invalidating a few files in this PR already. And if this gets merged to dev and therefore removed from cpt2 it will make things more difficult for me. Wdyt?

zesterer
zesterer reviewed May 11, 2021
View reviewed changes
bee-ledger/src/lib.rs Outdated Show resolved Hide resolved
zesterer
zesterer previously approved these changes May 12, 2021
View reviewed changes
@thibault-martinez thibault-martinez merged commit 51ec48a into iotaledger:dev May 12, 2021
@thibault-martinez thibault-martinez deleted the ledger-workers branch May 12, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zesterer zesterer zesterer approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@Adam-Gleave Adam-Gleave Adam-Gleave approved these changes

@Alex6323 Alex6323 Alex6323 left review comments

@bingyanglin bingyanglin Awaiting requested review from bingyanglin bingyanglin is a code owner

@louaykamel louaykamel Awaiting requested review from louaykamel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thibault-martinez @Alex6323 @zesterer @samuel-rufi @Adam-Gleave