Add encoding/decoding for termdeposit module #1379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepuchyr
reviewed
Feb 4, 2020
davepuchyr
reviewed
Feb 4, 2020
davepuchyr
reviewed
Feb 4, 2020
abefernan
reviewed
Feb 5, 2020
scripts/bnsd/genesis_app_state.json
Outdated
| }, | ||
| "account": { | ||
| "valid_name": "^[a-z0-9\\-_.]{3,64}$", | ||
| "valid_domain": "^[a-z0-9\\-_]+${3,16}", |
There was a problem hiding this comment.
Missing $ at end of regex.
There was a problem hiding this comment.
Great catch. The regex should be ^[a-z0-9\\-_]{3,16}$.
davepuchyr
reviewed
Feb 6, 2020
packages/iov-bns/src/types.ts
Outdated
| // Transactions: Term Deposit | ||
|
|
||
| export interface TermDepositBonus { | ||
| readonly lockingPeriod: number; |
There was a problem hiding this comment.
lockingPeriod should be lockinPeriod (without the "g"). We want depositors to "lock-in" their tokens.
davepuchyr
reviewed
Feb 6, 2020
scripts/bnsd/genesis_app_state.json
Outdated
| @@ -194,7 +194,7 @@ | |||
| }, | |||
| "account": { | |||
| "valid_name": "^[a-z0-9\\-_.]{3,64}$", | |||
| "valid_domain": "^[a-z0-9\\-_]+${3,16}", | |||
| "valid_domain": "^[a-z0-9\\-_]+${3,16}$", | |||
There was a problem hiding this comment.
valid_domain should be ^[a-z0-9\\-_]{3,16}$ (no "+" and only a single "$" at the end of the string).
albertandrejev
force-pushed
the
998-ponferrada-termdeposit-encoding
branch
from
b708da7
to
c7cba96
Compare
davepuchyr
reviewed
Feb 7, 2020
davepuchyr
reviewed
Feb 7, 2020
davepuchyr
approved these changes
Feb 10, 2020
albertandrejev
force-pushed
the
998-ponferrada-termdeposit-encoding
branch
from
d15cb8d
to
435cc91
Compare
abefernan
approved these changes
Feb 12, 2020
abefernan
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Types" part of the iov-one/ponferrada#997