Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Finalize go key split #2

Merged
merged 5 commits into from
Aug 26, 2016
Merged

Finalize go key split #2

merged 5 commits into from
Aug 26, 2016

Conversation

geoah
Copy link
Collaborator

@geoah geoah commented Aug 25, 2016

This should wrap up the split of go-key from go-ipfs.

  • Undoes gx rewrite
  • Adds travis-ci
  • Adds README and LICENCE
  • Publishes 1.0.0 to gx

@whyrusleeping if can please enable travis for this repo first so we can see that everything works as expected.

@RichardLitt
Copy link

Can you standardize the README to match other IPFS repositories?

@@ -0,0 +1,21 @@
The MIT License (MIT)

Copyright (c) 2016 Juan Batiz-Benet

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be Jeromy Johnson

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or Protocol Labs.

@whyrusleeping
Copy link
Contributor

@RichardLitt could you just do the standard readme thing like you've been doing on other repos?

@RichardLitt
Copy link

@whyrusleeping Don't have admin access to this repo, can't push to this branch. Add me?

@geoah
Copy link
Collaborator Author

geoah commented Aug 25, 2016

Sorry I didn't know there is template, if you an point me to it i can change it and use it for the other packages as well. Is it the same for ipfs and libp2p repos?

As for the licence i just included the one from go-ipfs where i got the code, I'll change it to protocol labs.

@whyrusleeping
Copy link
Contributor

@geoah we use standard readme: https://github.com/richardlitt/standard-readme

@RichardLitt added this repo to the admin group

@RichardLitt
Copy link

@geoah No worries. Most of the other repos should be standardized; it's a pretty straightforward conversion. It's the same for ipfs and libp2p. I can make an example minimal template if you like.

@geoah
Copy link
Collaborator Author

geoah commented Aug 26, 2016

@whyrusleeping @RichardLitt should be ok now.

@whyrusleeping
Copy link
Contributor

Sweet, LGTM

@whyrusleeping whyrusleeping merged commit 6be22a8 into master Aug 26, 2016
@whyrusleeping whyrusleeping deleted the chore/split-go-key branch August 26, 2016 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants