Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

[WIP] feat: adds tests for name.publish and name.resolve #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alanshaw
Copy link
Contributor

  • Adds test which:
    1. creates two nodes
    2. connects them (swarm.connect)
    3. calls name.publish on node0
    4. calls name.resolve(/ipns/${node0.peerid}) on the other

I could do with some advice possibly from the go-ipfs team(?), as step 4 fails with Error: Could not resolve name.. Why might that be?

Also:

  • Pulls repeated spawnWithId function into a module
  • Updates doc to reflect return value from go-ipfs

@ghost ghost assigned alanshaw Mar 29, 2018
@ghost ghost added the in progress label Mar 29, 2018
@victorb
Copy link
Contributor

victorb commented Mar 29, 2018

Should try to use the new experimental feature for pubsub resolve (but still test the old one as well), but with the flag --enable-namesys-pubsub together with --enable-pubsub-experiment will make publish/resolve a lot faster.

@alanshaw alanshaw changed the title [WIP] adds tests for name.publish and name.resolve [WIP] feat: adds tests for name.publish and name.resolve Apr 20, 2018
@daviddias
Copy link
Contributor

What's missing here?

@alanshaw
Copy link
Contributor Author

Just the fact that the tests don't pass and I couldn't figure out why...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants