This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
feat: Add promise based api #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All methods return a promise when not passed a callback Closes #80
dignifiedquire
force-pushed
the
promise
branch
from
d5937e3
to
9b74841
Compare
|
After the past discussions about having a promises implementations and the implications that would bring, this seems by far the most elegant solution (as it is almost minimal and only touches the code partially and gives the desired feature). Before merging, I would like everyone that chimed in on the promises API discussion to give their review (if possible). The discussion happened here #80 and the people involved are: @victorbjelkholm, @RichardLitt, @harlantwood, @travisperson and @bcomnes |
|
+100 |
|
I really hope this gets merged! |
|
LGTM! |
|
It is time.. :) |
|
whoo |
|
@jbenet You mentioned that you would like to discuss this. Here is the relevant PR for that discussion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All methods return a promise when not passed a callback
Closes #80