This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Fix the ping results
#556
Closed
Fix the ping results
#556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kubuxu any thoughts on why this happens? |
|
It has happened because What the code should do is parse the response as NDJSON (line by line) and look for |
|
@ngotchac wanna follow up on this PR? |
Kubuxu
suggested changes
Oct 9, 2017
There was a problem hiding this comment.
This isn't the right way to do it as API does not specify order of messages. See #556 (comment)
(cleaning up my CR queue)
5 tasks
ghost
assigned 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've see cases where the
pingresponse is in fact on 2 lines, the second one containing the Success (false), the Time and the Text. This happens for example if you try to ping your self.