This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
[WIP] refactor: use CIDv1 and encode with base32 by default #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: CIDs created by this module will default to v1 and will be base32 encoded by default.
refs ipfs/js-ipfs#1440
@achingbrain I could use your advice on the wisdom of this particular change. I think it's fine, I just wanted to confirm. It's used by these tests:
I've added
rawLeaves: false
because switching to CIDv1 enables it by default inunixfs-importer
but MFS explicitly disables it, hence we have to explicitly set it to false when callingunixfs-importer
in order to get the same hash.Depends on: