This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
refactor: remove Node.js and pull streams #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Dec 12, 2019
Depends on: * [ ] ipfs-inactive/js-ipfs-mfs#66
1 task
achingbrain
suggested changes
Dec 12, 2019
achingbrain
approved these changes
Dec 17, 2019
Also changes `stat` and `ls` to return CID's not strings from core and removes the `long` option from `ls` in core (is applied by CLI/HTTP API).
alanshaw
force-pushed
the
refactor/remove-streams
branch
from
7c289f4
to
c3ee120
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes
statandlsto return CID's not strings from core and removes thelongoption fromlsin core (is applied by CLI/HTTP API).refs ipfs-inactive/interface-js-ipfs-core#394
BREAKING CHANGE:
files.readPullStreamandfiles.readReadableStreamhave been removed.BREAKING CHANGE:
files.readnow returns an async iterable.BREAKING CHANGE:
files.lsPullStreamandfiles.lsReadableStreamhave been removed.BREAKING CHANGE:
files.lsnow returns an async iterable.BREAKING CHANGE:
files.lsresults now contain acidproperty (whose value is a CID instance) instead of ahashproperty.BREAKING CHANGE:
files.lsno longer takes alongoption (in core) - you will receive all data by default.BREAKING CHANGE:
files.statresult now contains acidproperty (whose value is a CID instance) instead of ahashproperty.