feat(libp2p/identify): can discover peer ids even if they are not passed in the multiaddr #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
feat/identify-without-peerid
branch
from
d6f3089
to
b1d60d6
Compare
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 21.13% 24.35% +3.22%
==========================================
Files 5 5
Lines 530 583 +53
==========================================
+ Hits 112 142 +30
- Misses 392 408 +16
- Partials 26 33 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aschmahmann
force-pushed
the
feat/identify-without-peerid
branch
from
b1d60d6
to
0e50d29
Compare
aschmahmann
commented
Jul 7, 2023
| } | ||
|
|
||
| return extractIdentifyInfo(h.Peerstore(), ai.ID) | ||
| } | ||
|
|
||
| func extractPeerIDFromError(inputErr error) (peer.ID, error) { |
There was a problem hiding this comment.
Note: this function is no fun and is brittle. Suggestions welcome for improvements.
…not passed in the multiaddr
aschmahmann
force-pushed
the
feat/identify-without-peerid
branch
from
0e50d29
to
973a280
Compare
|
merging, since this is better than the status quo and this repo is generally low on reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to libp2p/specs#458 and a useful debugging tool. This code would be much less brittle and cleaner if go-libp2p returned typed errors to check against (aside from the issue of whether it's reasonable for the core swarm functionality to allow the MITM behavior that can accompany dialing a multiaddr without a peerID).