Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more automated awesome-ipfs PRs #429

Merged
merged 28 commits into from
Sep 15, 2022
Merged

feat: more automated awesome-ipfs PRs #429

merged 28 commits into from
Sep 15, 2022

Conversation

SgtPooki
Copy link
Member

This PR is intended to replace #428

What kind of PR is this?

Select only one to speed up review/approval; i.e., don't lump an addition and a removal into a single PR.

  • [N/A] Adding something new to awesome-ipfs
  • [N/A] Editing something already listed on awesome-ipfs
  • [N/A] Removing something from awesome-ipfs
  • Something else (if so, please explain in the "Additional details" section below)

Pre-submit checklist

Please confirm ALL of the following before submitting your PR.

Additional details

Is there anything else we should know about this PR?

This PR is a part of addressing concerns raised in #420 and elsewhere, and adds the following features:

  • Automatically update README.md for users. All they need to do to contribute is modify the data/** files.
  • Runs awesome_bot via github actions instead of via circleci
  • Posts comment to PRs giving insight into what was changed.
    • If .github/** was changed, a regular message will be displayed.
    • If data/** was changed
      • A message will be displayed indicating the YAML data has been edited.
      • If there are broken links, danger-js will fail the PR
    • If src/** was changed, a warning will be displayed
    • If scripts/** was changed, a warning will be displayed

See SgtPooki#2 for an example of what these changes do. You can look at the edit history for SgtPooki#2 (comment) to see the different types of messages.

SgtPooki and others added 26 commits September 13, 2022 18:39
@SgtPooki
chore: ignore files created by awesome_bot
9c9c053
@SgtPooki
feat: auto-update README.md when PRs are created
6949c82
@SgtPooki
feat: use danger to post awesome_bot results on PRs
01d4e7f
@SgtPooki
Merge pull request #1 from SgtPooki/feature/add-danger
d989cd9 
feat: use danger to post awesome_bot results on PRs
@SgtPooki
chore: wut
7e521d6
@SgtPooki
Update pull_requests.yml
6f37630
@SgtPooki
chore: fake-test
e6877f2
@SgtPooki
adjust branch used by github-push-action
3866414
@SgtPooki
chore: ensure checkout uses the branch
b3fcefa
@github-actions
chore: update README.md
edf4287
@SgtPooki
chore: modify dangerfile and workflow ordering
ad73266
@SgtPooki
remove fake addition to videos.yaml
7cb22e8
@github-actions
chore: update README.md
f2f93d2
@SgtPooki
chore: rename pull_requests.yml
db5bb39
@SgtPooki
temp: always display awesomeBot results
acaef1f
@SgtPooki
Revert "temp: always display awesomeBot results"
f74ae7c 
This reverts commit acaef1f.
@SgtPooki
chore(deps): install danger as devDep
2f9773d
@SgtPooki
feat: cache node_modules and readme
0ffe703
@SgtPooki
Merge pull request #2 from SgtPooki/feature/pr-test
81ee8db 
chore: ensure PRs are handled appropriately
@SgtPooki
Update pull_requests.yml
7589257
@SgtPooki
chore: remove ad-m/github-push-action
7368788 
see ad-m/github-push-action#104
@SgtPooki
tmp: PR-demo
8bed132
@actions-user
Rebuild
b9d982a
@SgtPooki
Revert "tmp: PR-demo"
5f0adcf 
This reverts commit 8bed132.
@actions-user
Rebuild
c0ef942
@SgtPooki
fix: no need to push readme update
a56171d 
* fix: no need to push readme update

readme is updated during 'Rebuild' commit from data.yml

* chore: run danger via npm script instead of npx
@ipfs-gui-bot
Copy link
Collaborator

ipfs-gui-bot commented Sep 15, 2022 •
edited
Loading

Warnings
⚠️ Changes were made to the scripts folder.
Messages
📖 Changes were made within the .github folder.

Generated by 🚫 dangerJS against 15a552a

@SgtPooki
Copy link
Member Author

Accepted invitation for ipfs-gui-bot to this repo so we can get passed this error:
image

@SgtPooki
Copy link
Member Author

from https://github.com/ipfs/awesome-ipfs/actions/runs/3063541346/jobs/4945872464

image

@SgtPooki
Copy link
Member Author

circleci is still failing saying skiff.com is a 403: https://app.circleci.com/pipelines/github/ipfs/awesome-ipfs/1160/workflows/defde02d-f26d-4675-ba90-7b9aa4ae58a5/jobs/1867. We need to remove circleci

@SgtPooki SgtPooki marked this pull request as ready for review September 15, 2022 22:49
@SgtPooki SgtPooki mentioned this pull request Sep 15, 2022
Closed
3 tasks
@SgtPooki
feat: remove replace circleci cron with github action
15a552a 
this github action should open a PR removing broken links automatically
@SgtPooki SgtPooki requested a review from lidel September 15, 2022 23:00
@SgtPooki SgtPooki mentioned this pull request Sep 15, 2022
Closed
11 tasks
@SgtPooki SgtPooki merged commit 6d5eef1 into master Sep 15, 2022
@SgtPooki SgtPooki deleted the feature/improve-PR-story branch September 15, 2022 23:41
@2color
Copy link
Member

2color commented Sep 16, 2022

Awesome! Thanks for pushing this @SgtPooki

@baby636 baby636 mentioned this pull request Oct 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel Awaiting requested review from lidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SgtPooki @ipfs-gui-bot @2color @actions-user