Skip to content

Commit

Permalink
fix(bitswap): log unexpected blocks to debug level (#711)
Browse files Browse the repository at this point in the history
(cherry picked from commit f98e66c)
  • Loading branch information
lidel committed Nov 7, 2024
1 parent ca8df33 commit 611af32
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 2 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,12 @@ The following emojis are used to highlight certain changes:

### Changed

- updated to go-libp2p to [v0.37.0](https://github.com/libp2p/go-libp2p/releases/tag/v0.37.0)

### Removed

### Fixed

- Fix panic if current live count is greater than broadcast limit [#702](https://github.com/ipfs/boxo/pull/702)
- `bitswap/client` no longer logs `"Received provider X for cid Y not requested` to ERROR level, moved to DEBUG [#771](https://github.com/ipfs/boxo/pull/711)

### Security

## [v0.24.2]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ func (rpm *receivedProviderMessage) debugMessage() {
func (rpm *receivedProviderMessage) handle(pqm *ProviderQueryManager) {
requestStatus, ok := pqm.inProgressRequestStatuses[rpm.k]
if !ok {
log.Errorf("Received provider (%s) for cid (%s) not requested", rpm.p.String(), rpm.k.String())
log.Debugf("Received provider (%s) for cid (%s) not requested", rpm.p.String(), rpm.k.String())

Check warning on line 358 in bitswap/client/internal/providerquerymanager/providerquerymanager.go

View check run for this annotation

Codecov / codecov/patch

bitswap/client/internal/providerquerymanager/providerquerymanager.go#L358

Added line #L358 was not covered by tests
return
}
requestStatus.providersSoFar = append(requestStatus.providersSoFar, rpm.p)
Expand Down

0 comments on commit 611af32

Please sign in to comment.