Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: return 400 on /ipfs/invalid-cid #200

Closed
2 tasks
hacdias opened this issue Mar 9, 2023 · 0 comments · Fixed by #205
Closed
2 tasks

gateway: return 400 on /ipfs/invalid-cid #200

hacdias opened this issue Mar 9, 2023 · 0 comments · Fixed by #205
Assignees
Labels
topic/gateway Issues related to HTTP Gateway

Comments

@hacdias
Copy link
Member

hacdias commented Mar 9, 2023

On #185 we unified the behaviour of all resolution errors to return 500. However, this raised the concern that requests to /ipfs/invalid-cid should still return 400. Initially, we decided not to do so since we could not find an easy way to return it and with a unified behaviour, it would be easier for implementations.

TODO

@hacdias hacdias added the need/triage Needs initial labeling and prioritization label Mar 9, 2023
@hacdias hacdias self-assigned this Mar 9, 2023
@hacdias hacdias added topic/gateway Issues related to HTTP Gateway and removed need/triage Needs initial labeling and prioritization labels Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/gateway Issues related to HTTP Gateway
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant