Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: return 400 Bad Request on Invalid CIDs #384

Merged
merged 1 commit into from
Mar 27, 2023
Merged

docs: return 400 Bad Request on Invalid CIDs #384

merged 1 commit into from
Mar 27, 2023
+2 −1

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 15, 2023

@hacdias hacdias requested a review from lidel as a code owner March 15, 2023 15:34
@hacdias hacdias mentioned this pull request Mar 15, 2023
Merged
6 tasks
@hacdias hacdias self-assigned this Mar 15, 2023
@hacdias hacdias mentioned this pull request Mar 20, 2023
Closed
2 tasks
@hacdias hacdias changed the title Return 400 Bad Request on Invalid CIDs docs: return 400 Bad Request on Invalid CIDs Mar 20, 2023
@hacdias
Copy link
Member Author

hacdias commented Mar 27, 2023

ping @lidel

lidel
lidel approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, make sure it is not lost and re-applied to #382 🙏

@lidel lidel merged commit a22c7c3 into main Mar 27, 2023
@lidel lidel deleted the libipfs/issues/200 branch March 27, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees

@hacdias hacdias

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hacdias @lidel