fix: delegated routing of legacy RSA peerids #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This ensures /routing/v1/peers endpoint accepts all variants of PeerIDs we see in the wild, namely: - cidv1-libp2p-key-ed25519-peerid - base58-ed25519-peerid - cidv1-libp2p-key-rsa-peerid - base58-rsa-peerid
lidel
force-pushed
the
fix/delegated-routing-legacy-rsa-peerids
branch
from
31123dc
to
d5c1c6c
Compare
hacdias
changed the title
hacdias
approved these changes
May 15, 2024
wenyue
pushed a commit
to wenyue/boxo
that referenced
this pull request
Oct 17, 2024
This ensures /routing/v1/peers endpoint accepts all variants of PeerIDs we see in the wild, namely: - cidv1-libp2p-key-ed25519-peerid - base58-ed25519-peerid - cidv1-libp2p-key-rsa-peerid - base58-rsa-peerid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues work from #585 which fixed support for ED25519 as BAse58. Here, we add correct support for RSA PeerIDs.
I also added test matrix for all PeerID variants versions to ensure we don't regress.
After this is merged,
/routing/v1/peersendpoint will accept all variants of PeerIDs we see in the wild.Namely:
@hacdias if this looks good, mind bubbling up to Someguy, and making new release, and deploying to https://delegated-ipfs.dev/?