refactor: bitswap client does not need ProviderQueryManager #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bitswap Client does not to hold a reference to the provider query manager. The session maintains the ProviderQueryManager reference.
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #676 +/- ##
==========================================
+ Coverage 60.30% 60.32% +0.02%
==========================================
Files 243 243
Lines 31019 31018 -1
==========================================
+ Hits 18705 18711 +6
+ Misses 10649 10643 -6
+ Partials 1665 1664 -1
|
lidel
changed the title
lidel
approved these changes
Oct 15, 2024
gammazero
added a commit
that referenced
this pull request
Oct 22, 2024
btswap client does not need ProviderQueryManager The bitswap Client does not to hold a reference to the provider query manager. The session maintains the ProviderQueryManager reference. (cherry picked from commit 08fb71d)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bitswap
Clientdoes not to hold a reference to theProviderQueryManager. The session maintains theProviderQueryManagerreference.