fix(bitswap/session): cleanup live wants on cancel #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise live wants get rebroadcasted/requested forever, even when we cancelled those.
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #690 +/- ##
==========================================
+ Coverage 60.29% 60.37% +0.08%
==========================================
Files 243 243
Lines 31019 31029 +10
==========================================
+ Hits 18702 18733 +31
+ Misses 10649 10631 -18
+ Partials 1668 1665 -3
|
gammazero
reviewed
Oct 17, 2024
gammazero
added a commit
that referenced
this pull request
Oct 17, 2024
Otherwise, live wants get rebroadcasted forever, even when we canceled those. This PR exists to have a branch to test #690
gammazero
approved these changes
Oct 18, 2024
lidel
reviewed
Oct 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, live wants get rebroadcasted forever, even when we canceled those.