Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: update CI config files #113

Closed
wants to merge 11 commits into from
Closed

sync: update CI config files #113

wants to merge 11 commits into from

Conversation

web3-bot
Copy link
Collaborator

@web3-bot web3-bot commented Apr 23, 2021

Syncing to commit protocol/.github@110e0ad.

@welcome

This comment has been minimized.

@Stebalien
Copy link
Member

Ok, badger is leaking goroutines left and right here and I'm ready to throw in the towel.

@marten-seemann
Copy link
Member

Ok, badger is leaking goroutines left and right here and I'm ready to throw in the towel.

How does this affect us in production?

@Stebalien
Copy link
Member

How does this affect us in production?

It probably doesn't? Because we don't rapidly create and close iterators.

But I'm not sure how to best fix this. We could add a bunch of sleeps... Or we could test "in memory" (or in memory, in CI). But that might hide some bugs?

@web3-bot web3-bot force-pushed the web3-bot/sync branch 9 times, most recently from 7d6f082 to 552452b Compare February 8, 2023 09:07
@web3-bot web3-bot force-pushed the web3-bot/sync branch 3 times, most recently from 049010b to ab4b572 Compare March 2, 2023 10:36
@web3-bot web3-bot force-pushed the web3-bot/sync branch 4 times, most recently from 29d13f4 to cf7548d Compare March 15, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants