Network errors not propagating up to RegisterNetworkErrorListener

[dirkmc]

It seems that a listener registered with RegisterNetworkErrorListener() will not receive errors emitted by the message queue.

For example the error events published on lines 178 and 187 of messagequeue.go:

go-graphsync/messagequeue/messagequeue.go

Lines 166 to 188 in 11d30c6

	func (mq *MessageQueue) sendMessage() {
	message, topic := mq.extractOutgoingMessage()
	if message == nil || message.Empty() {
	return
	}
	mq.eventPublisher.Publish(topic, Event{Name: Queued, Err: nil})
	defer mq.eventPublisher.Close(topic)
	err := mq.initializeSender()
	if err != nil {
	log.Infof("cant open message sender to peer %s: %s", mq.p, err)
	// TODO: cant connect, what now?
	mq.eventPublisher.Publish(topic, Event{Name: Error, Err: fmt.Errorf("cant open message sender to peer %s: %w", mq.p, err)})
	return
	}
	for i := 0; i < maxRetries; i++ { // try to send this message until we fail.
	if mq.attemptSendAndRecovery(message, topic) {
	return
	}
	}
	mq.eventPublisher.Publish(topic, Event{Name: Error, Err: fmt.Errorf("expended retries on SendMsg(%s)", mq.p)})
	}