Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error listener on receiver #136

Merged
merged 6 commits into from
Dec 22, 2020

Conversation

hannahhoward
Copy link
Collaborator

Goals

fix #129

Implementation

  • Add new RegisterReceiveNetworkErrorListener hook
  • Modify ReceiveError method on network interface to pass peer
  • Call ReceiverNetworkErrorListeners in ReceiveError callback

Copy link
Collaborator

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! 👍

graphsync.go Outdated Show resolved Hide resolved
graphsync.go Outdated Show resolved Hide resolved
listeners/listeners.go Outdated Show resolved Hide resolved
@hannahhoward hannahhoward force-pushed the feat/add_error_listener_on_receiver branch from 1c67e28 to 298b33d Compare December 22, 2020 04:19
@hannahhoward hannahhoward merged commit ae3cd24 into master Dec 22, 2020
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
@mvdan mvdan deleted the feat/add_error_listener_on_receiver branch December 15, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface to register listeners for network errors on receiving side
2 participants