Add optional HTTP comparison #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
feat/transfer_testplan
branch
from
0ffc357
to
2db8f7a
Compare
acruikshank
approved these changes
Mar 2, 2021
testplans/graphsync/main.go
Outdated
| if runHTTPTest { | ||
| runenv.R().RecordPoint(measurement+",transport=graphsync", float64(dur)/float64(time.Second)) | ||
| } else { | ||
| runenv.R().RecordPoint(measurement, float64(dur)/float64(time.Second)) |
There was a problem hiding this comment.
The data will be easier to process if you add ",transport=http" here.
Add configuration for memory buffering and disabling unlimited options, also add timing of responses
hannahhoward
force-pushed
the
feat/transfer_testplan
branch
from
41b2b5d
to
43ae998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Provide a mechanism to compare graphsync against HTTP.
Implementation
Adds setup of HTTP to the default testplan. Can be turned on and off. Default is on.