Resolve 175 race condition, no change to hook timing #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move unused query executor dependencies to response manager
realign requestqueud and incoming request timing while maintaining fix to bug behavior
raulk
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
I'm not a Graphsync expert nor do I have the experience to know exactly what's going on here at the code level. But @hannahhoward and I iterated through various solutions offband, and this made the failing tests on Lotus side succeed, while assuring that it doesn't cause a regression with the queued hooks.
hannahhoward
added a commit
that referenced
this pull request
Aug 5, 2021
* feat: fire network error when network disconnects during request (#164) * release: 0.6.1 * Better logging for Graphsync traversal (#167) * log gs traversal * Apply suggestions from code review Co-authored-by: dirkmc <[email protected]> * add debug logs * add debug logs Co-authored-by: dirkmc <[email protected]> * release: v0.6.2 (#168) * Fix/log blockstore reads (#169) * log gs traversal * Apply suggestions from code review Co-authored-by: dirkmc <[email protected]> * add debug logs * fixed logging * Apply suggestions from code review Co-authored-by: dirkmc <[email protected]> * fixed error Co-authored-by: dirkmc <[email protected]> * release: v0.6.3 (#170) * request queued hook * test request queued hook * release: v0.6.4 * Resolve 175 race condition, no change to hook timing (#178) * feat(requestmanager): add request timing (#181) * Add cancel request and wait function (#185) * fix(responsemanager): fix error codes (#182) enforce much tighter consistency with graphsync spec in usage of error codes * refactor: replace particular request not found errors with public error (#188) * release: 0.6.8 Co-authored-by: dirkmc <[email protected]> Co-authored-by: Aarsh Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
fix #175
Implementation
This builds of #176 but avoids moving hooks around in terms of timing in any substantive way. Rather, it cleans up hook processing to insure that request hooks are processed only on the main response manager thread, so that there aren't races with any calls made during hook processing.