Make sure linkcontext is passed #207
Conversation
Ensure all calls that ask for LinkContext are properly passed from function to function
hannahhoward
requested review from
adlrocha and
gammazero
and removed request for
gammazero
| @@ -166,7 +166,7 @@ func (t *traverser) checkState() { | |||
| func (t *traverser) writeDone(err error) { | |||
| select { | |||
| case <-t.ctx.Done(): | |||
| case t.stateChan <- state{true, err, nil, ipld.LinkContext{}}: | |||
| case t.stateChan <- state{true, err, nil, ipld.LinkContext{Ctx: t.ctx}}: | |||
There was a problem hiding this comment.
Just to double check that I am not missing anything. Here we are instantiating a LinkContext exclusively from the process context because there is no parent LinkContext to propagate, right? I ask because building a LinkContext directly from the process context may not propagate certain values in the context. But as this is done at the beginning and the end of the traversal I think it should be fine.
There was a problem hiding this comment.
LGTM. One question, how hard would it be to write a test that checks if context values are actually passed in a traversal? That way we can track that we don't break LinkContext propagation in the future.
We can do it if folks start using this feature extensively, but in case it is straightforward and it is worth doing it now.
Goals
LinkContexts passed during selector traversals should always pass through our intercepted loading system so they make it to the base BlockReadOpener / BlockWriteOpener functions on the linksystem passed during setup
Implementation