Free memory on request finish #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
feat/cleanup-allocations
branch
from
5272e6b
to
6506c45
Compare
willscott
approved these changes
Oct 6, 2021
| @@ -43,14 +43,20 @@ func New(unverifiedBlockStore UnverifiedBlockStore) *ResponseCache { | |||
|
|
|||
| // FinishRequest indicate there is no more need to track blocks tied to this | |||
| // response | |||
| func (rc *ResponseCache) FinishRequest(requestID graphsync.RequestID) { | |||
| func (rc *ResponseCache) FinishRequest(requestID graphsync.RequestID) uint64 { | |||
There was a problem hiding this comment.
add comment indicating this return value is the total length of data over the blocks that have been pruned? (if i'm reading that right)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
fix #236
Our issue here is with the request side allocation -- we aren't freeing memory properly when requests terminate early.
Implementation