message/pb: stop using gogo/protobuf #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a project, it has mostly been unmaintained since 2019. Having three implementations of protobuf in graphsync is unfortunate; we really shouldn't need golang/protobuf and gogo/protobuf. Luckily, we only used gogo to set two fields as non-nullable, and that detail was never actually used in practice. Those extra bits of info would only be used by protoc-gen-gofast, gogo's generator, while we've always used the regular protoc-gen-go. As a bonus, golang/protobuf was only pulled by gogo/protobuf, so we can drop both from go.mod. The generated code doesn't change at all in terms of functionality.
This comment has been minimized.
This comment has been minimized.
rvagg
pushed a commit
that referenced
this pull request
Nov 30, 2021
As a project, it has mostly been unmaintained since 2019. Having three implementations of protobuf in graphsync is unfortunate; we really shouldn't need golang/protobuf and gogo/protobuf. Luckily, we only used gogo to set two fields as non-nullable, and that detail was never actually used in practice. Those extra bits of info would only be used by protoc-gen-gofast, gogo's generator, while we've always used the regular protoc-gen-go. As a bonus, golang/protobuf was only pulled by gogo/protobuf, so we can drop both from go.mod. The generated code doesn't change at all in terms of functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)