Remove accidental legacy field, fix metrics #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, I would have added a test for the stats here but I'm really struggling to figure out where to run it so we have no race condition but get accurate values |
willscott
approved these changes
Dec 11, 2021
hannahhoward
added a commit
that referenced
this pull request
Dec 11, 2021
fix(impl): remove accidental legacy field (#310) feat: add basic tracing for responses (#291) * feat: add basic tracing for responses * fix: add assertions for response completion * fix: improve test synchronization/drainage * fix(responsemanager): remove uninformative span flags Co-authored-by: hannahhoward <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Well, I guess this is the price you pay for not having testing on stats! we broke the request queue stats when we did the request queue refactor
Implementation