Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept/Reject requests up front #384

Merged
merged 6 commits into from
Jun 25, 2022
Merged

Accept/Reject requests up front #384

merged 6 commits into from
Jun 25, 2022

Commits on Jun 9, 2022

  1. feat(responsemanager): move request validation to front 

    it makes much more sense to reject requests early than put them in the processing queue. While there
may be a minimal cost to evaluating a hook, there is no reason to wait to send a rejection
    @hannahhoward
    hannahhoward committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    c7d53b2 View commit details
    Browse the repository at this point in the history

  2. refactor(listeners): cleanup request processing listeners

    @hannahhoward
    hannahhoward committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    2f89a68 View commit details
    Browse the repository at this point in the history

  3. test(responsemanager): verify response procesisng test 

    add test to verify response processing listerner called
    @hannahhoward
    hannahhoward committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    a65c83c View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2022

  1. test(graphsync): add hooks test 

    add test for hooks process (issue caught and fixed in process) and address PR comments
    @hannahhoward
    hannahhoward committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    a1774a5 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. Merge branch 'main' into feat/move-request-processing-to-front

    @hannahhoward
    hannahhoward authored Jun 13, 2022
    Configuration menu
    Copy the full SHA
    f3c7657 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2022

  1. Merge branch 'main' into feat/move-request-processing-to-front

    @hannahhoward
    hannahhoward authored Jun 25, 2022
    Configuration menu
    Copy the full SHA
    2e4e7eb View commit details
    Browse the repository at this point in the history