feat: update the peer task queue #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
commented
Mar 11, 2020
| taskDataChan := make(chan *responseTaskData) | ||
| var taskData *responseTaskData | ||
| for { | ||
| nextTaskBlock := rm.queryQueue.PopBlock() | ||
| for nextTaskBlock == nil { | ||
| pid, tasks, _ := rm.queryQueue.PopTasks(targetWork) |
There was a problem hiding this comment.
Third return value is "remaining work" for this peer, which we really don't care about.
| for _, task := range nextTaskBlock.Tasks { | ||
| key := task.Identifier.(responseKey) | ||
| for _, task := range tasks { | ||
| key := task.Topic.(responseKey) |
There was a problem hiding this comment.
Why do we put the peer ID in the Topic/Identifier?
| @@ -292,7 +294,8 @@ func (prm *processRequestMessage) handle(rm *ResponseManager) { | |||
| cancelFn: cancelFn, | |||
| request: request, | |||
| } | |||
| rm.queryQueue.PushBlock(prm.p, peertask.Task{Identifier: key, Priority: int(request.Priority())}) | |||
| // TODO: Use a better work estimation metric. | |||
| rm.queryQueue.PushTasks(prm.p, peertask.Task{Topic: key, Priority: int(request.Priority()), Work: 1}) | |||
There was a problem hiding this comment.
At the moment, I'm just assigning every item a work of "one".
|
We backed out of this for some reason but nobody can remember why. We're going to re-implement it and 🤞. If we have to back out of it again, we'll make sure to write down why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that go-ipfs imports graphsync, we need to use the same peertaskqueue
implementation in bitswap as graphsync.