Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(message): regen protobuf code #79

Merged
merged 1 commit into from
Jul 30, 2020
Merged

fix(message): regen protobuf code #79

merged 1 commit into from
Jul 30, 2020

Conversation

hannahhoward
Copy link
Collaborator

Goals

Fix potential overflow errors in unmarshal code for protobuf messages

Implementation

And older version of gogo-protobuf had generated our message.pb.go code which was lacking checks for negative indexes due to integer overflow issues.

I installed the latest version of protoc-gen-gogofaster (the version we use) and regenerated to get these changes, which insert checks for negative values.

protobuf generated code was generated with old version of gogo-protobuf
@hannahhoward hannahhoward merged commit d996af3 into master Jul 30, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
@mvdan mvdan deleted the fix/protocode branch December 15, 2021 14:15
marten-seemann pushed a commit that referenced this pull request Mar 2, 2023
* Emit events with received cids (#71)

* persist received cids on channel state.

* Send, Receive and Validate Restart requests (#75)

* Send, Receive and Validate Requests

* Initiating and Responding Tests and bug fixes (#76)

* Testing for resuming data transfer work

* Cleanup Push Restarts PR  (#79)

* cleanup of restart PR

* link the peers

* Tests for pull restarts (#84)

* tests for pull restarts

* Merge Tests cleanup work (#92)

* cleanup of restart PR

* cleanup timedout channels (#93)

* backward compatibility of restart (#96)

* backward compatibility of restart

* changes and tests

* more tests

* better error handling for restarts

* feat(message): switch to cbor map encoding (#97)

switch to cbor map encoding for the 1_1 message protocol

* feat(channels): setup datastore migrations (#99)

setup datatransfer channels so they migrate over successfully

Co-authored-by: Hannah Howard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants