This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 178
Add additional publish function for more fine grained control of IPNS record publishing #91
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a9ebe95
added additional publish method
bonedaddy 1c2767e
removed print statements
bonedaddy d29f92e
Added tests, cleaned up publish code, added additional function
bonedaddy 18615a8
removed duplicated code, made use of `req.Opts`
bonedaddy 980c8a5
updated tests, slight changes to syntax.
bonedaddy a67bcdb
added small change
bonedaddy 739f959
ran gofmt
bonedaddy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
package shell | ||
|
||
import ( | ||
"fmt" | ||
"testing" | ||
"time" | ||
) | ||
|
||
var examplesHashForIPNS = "/ipfs/Qmbu7x6gJbsKDcseQv66pSbUcAA3Au6f7MfTYVXwvBxN2K" | ||
var testKey = "self" // feel free to change to whatever key you have locally | ||
|
||
func TestPublishDetailsWithKey(t *testing.T) { | ||
t.Skip() | ||
shell := NewShell("localhost:5001") | ||
|
||
resp, err := shell.PublishWithDetails(examplesHashForIPNS, testKey, time.Second, time.Second, false) | ||
if err != nil { | ||
t.Fatal(err) | ||
} | ||
|
||
if resp.Value != examplesHashForIPNS { | ||
t.Fatalf(fmt.Sprintf("Expected to receive %s but got %s", examplesHash, resp.Value)) | ||
} | ||
} | ||
|
||
func TestPublishDetailsWithoutKey(t *testing.T) { | ||
t.Skip() | ||
shell := NewShell("localhost:5001") | ||
|
||
resp, err := shell.PublishWithDetails(examplesHashForIPNS, "", time.Second, time.Second, false) | ||
if err != nil { | ||
t.Fatal(err) | ||
} | ||
|
||
if resp.Value != examplesHashForIPNS { | ||
t.Fatalf(fmt.Sprintf("Expected to receive %s but got %s", examplesHash, resp.Value)) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd put it above/closer to
json.Unmarshal
lineThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! :D